Skip to content

Conversation

mariostieriansys
Copy link
Collaborator

As a requirement to support multiple versions of EnSight/PyEnSight on AnsysLab/OnScale Notebook we have the need to version the ansys/nexus folder in the nexus### distribution.

This PR reflects the changes needed in PyADR once the EnSight change is merged.

A fallback is provided if the version of ADR being used is < 242

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (3134fd3) 75.94% compared to head (191c686) 75.83%.

Files Patch % Lines
...ynamicreporting/core/utils/report_download_html.py 79.16% 3 Missing and 2 partials ⚠️
...ynamicreporting/core/utils/report_remote_server.py 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   75.94%   75.83%   -0.12%     
==========================================
  Files          16       16              
  Lines        5002     5016      +14     
  Branches     1052     1055       +3     
==========================================
+ Hits         3799     3804       +5     
- Misses        854      860       +6     
- Partials      349      352       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@margalva margalva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In adr_report there's a wrapper around the export as html capability. We should probably add there as well the ability to pass the ansys_version, in case someone runs pydynamicreporting on top of an older ansys installation.
So inside export_html() you have self.service.serverobj.export_report_as_html()
Add to that method an optional ansys_version that comes from self.service._ansys_version, and eventually gets passed into the ReportDownloadHTML definition. I think this is the best approach, if you agree.

@mariostieriansys mariostieriansys dismissed margalva’s stale review January 10, 2024 16:57

Since you are not available to review the changes, Randy is doing the review

@mariostieriansys mariostieriansys merged commit 509228a into main Jan 10, 2024
@mariostieriansys mariostieriansys deleted the mostieri/nexus_ansys_versioning branch January 10, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants