-
Notifications
You must be signed in to change notification settings - Fork 5
Mostieri/nexus ansys versioning #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 75.94% 75.83% -0.12%
==========================================
Files 16 16
Lines 5002 5016 +14
Branches 1052 1055 +3
==========================================
+ Hits 3799 3804 +5
- Misses 854 860 +6
- Partials 349 352 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In adr_report there's a wrapper around the export as html capability. We should probably add there as well the ability to pass the ansys_version, in case someone runs pydynamicreporting on top of an older ansys installation.
So inside export_html() you have self.service.serverobj.export_report_as_html()
Add to that method an optional ansys_version that comes from self.service._ansys_version, and eventually gets passed into the ReportDownloadHTML definition. I think this is the best approach, if you agree.
Since you are not available to review the changes, Randy is doing the review
As a requirement to support multiple versions of EnSight/PyEnSight on AnsysLab/OnScale Notebook we have the need to version the ansys/nexus folder in the nexus### distribution.
This PR reflects the changes needed in PyADR once the EnSight change is merged.
A fallback is provided if the version of ADR being used is < 242