Making h5py an optional dependency, not installed by default #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raph-luc
requested review from
mkundu1,
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
hpohekar and
h-krishnan
as code owners
mkundu1
approved these changes
Oct 24, 2023
prmukherj
approved these changes
Oct 25, 2023
raph-luc
added a commit
that referenced
this pull request
Oct 25, 2023
Merged
raph-luc
added a commit
that referenced
this pull request
Oct 26, 2023
* Fix vale warnings (#2139) * fix tensor type for displacement variable (#2145) * Fix set_state implementation for command argument instance. (#2147) * Update flobject.py (#2148) * SVAR Doc (#1635) * Test to catch Watchdog launch errors, and improved Watchdog behavior on Windows (#2144) * Cavitation Model Example And Example Warning Fix (#2102) * Add type annotations for some modules under services (#2108) * More robust Windows launch command for Watchdog (#2167) * Making h5py an optional dependency, not installed by default (#2171) * Expose settings root like in pyconsole. (#2149) * Remove timeout loop in FluentConnection (#2126) * Fix SVAR doc (#2172) --------- Co-authored-by: Mainak Kundu <94432368+mkundu1@users.noreply.github.com> Co-authored-by: Oleg Chernukhin <92750311+ochernuk@users.noreply.github.com> Co-authored-by: Prithwish Mukherjee <109645853+prmukherj@users.noreply.github.com> Co-authored-by: Harshal Pohekar <106588300+hpohekar@users.noreply.github.com> Co-authored-by: Aseem Jain <95020968+ajain-work@users.noreply.github.com> Co-authored-by: Prithwish Mukherjee <prithwish.mukherjee@ansys.com> Co-authored-by: Adam Boutin <143635850+ansaboutin@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses remaining vulnerability in #1552
To be superseded by #2096 when the
pyfluent-readerpackage is publishedBy default,
pip install ansys-fluent-coreor installing from a pre-built wheel file won't installh5pyanymore.To get data and case file reader functionality, users will need to:
pip install ansys-fluent-core[reader]pip install -e .[reader]for developmentpip install ansys_fluent_core-0.19.dev0-py3-none-any.whl[reader]from a wheel file