Custom Higher Level Exceptions

[hpohekar]

• Added higher level exceptions.
• Corrected existing exceptions.
• Updated existing tests.
• Added new tests.
• Update new exception names
• Update error message
• Update docstring of exception class
• Add error message at the definition of exception class
• Update tests - just raise and catch exceptions.
• Correct grammar of existing error messages.
• Incorporate some changes of TaskObject updates. #2150.

[raph-luc]

Looks good to me.

By the way, do you plan on adding more tests for the custom exceptions? I think that would be a good addition

[hpohekar]

Looks good to me.

By the way, do you plan on adding more tests for the custom exceptions? I think that would be a good addition

Yes, we will add more tests. I haven't explored all test files yet.

[hpohekar]

@seanpearsonuk

In yesterday's discussion you have mentioned perfect point of simultaneous implementation of suggestions from multiple reviewers makes the PR chaotic.

Personally I try to avoid merging a PR with lot of commits therefore I end up in creating multiple PRs for same task.

Actually, the first PR was in draft mode and it was work in progress. I hadn't completed all tasks required to get it ready for review, but multiple suggestions were started coming from reviewers which is perfectly fine.

I remember that your first comment was about exact behavior that we wanted, but I did not continue my own design approach.

The only issue was I kept myself too much open to address each and every suggestion by implementing it directly without completing my own design approach first. I agree that there was a regression initially but eventually it would have caught in testing. Testing files were not updated at that time.

Customized exceptions is general in terms of naming of exceptions and error messages. I agree that each developer can think to refine exception name and message again and again to help user to get better understanding of error scenario based on our own experience and expertise.

I have created task list based on your suggestions and I will implement it incrementally.

Thank you.

[hpohekar]

@seanpearsonuk This PR is ready.