Skip to content

Factory pattern in launch_fluent #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Nov 29, 2023
Merged

Factory pattern in launch_fluent #2252

merged 41 commits into from
Nov 29, 2023

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Nov 15, 2023 •
edited
Loading

  • Apply Factory Pattern in launch_fluent()
  • Test launch_fluent() in local session
  • Test launch_fluent() in Ansys Lab
  • Add docstrings
  • Construct launcher object of given type
  • Make launcher interface callable
  • Launch Standalone independently
  • Add tests for StandaloneLauncher
  • Launch PIMLauncher independently
  • Add tests for PIMLauncher
  • Launch DockerLauncher independently
  • Add tests for DockerLauncher
  • Move each Launcher to separate files.
  • Resolve import issues
  • Create a separate module for shared launcher utilities
  • Test local sessions again after restructuring
  • Test pim sessions again after restructuring
  • Test connect_to_fluent - found 1 bug - resolved in current PR remote_file_handler is None if we use connect_to_fluent #2272

@hpohekar hpohekar linked an issue Nov 15, 2023 that may be closed by this pull request
Apply the factory pattern in launch code #1781
Closed
@hpohekar hpohekar marked this pull request as draft November 15, 2023 14:40
seanpearsonuk
seanpearsonuk reviewed Nov 15, 2023
View reviewed changes
mkundu1
mkundu1 reviewed Nov 18, 2023
View reviewed changes
mkundu1
mkundu1 reviewed Nov 18, 2023
View reviewed changes
@hpohekar hpohekar marked this pull request as ready for review November 20, 2023 14:47
seanpearsonuk
seanpearsonuk reviewed Nov 20, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Nov 20, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Nov 21, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Nov 21, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Nov 21, 2023
View reviewed changes
@hpohekar hpohekar marked this pull request as ready for review November 23, 2023 07:45
@hpohekar hpohekar linked an issue Nov 23, 2023 that may be closed by this pull request
remote_file_handler is None if we use connect_to_fluent #2272
Closed
hpohekar
hpohekar commented Nov 23, 2023
View reviewed changes
@hpohekar hpohekar mentioned this pull request Nov 23, 2023
Merged
@hpohekar
Copy link
Collaborator Author

@seanpearsonuk This PR is ready.

seanpearsonuk
seanpearsonuk reviewed Nov 23, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Nov 23, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Nov 29, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Nov 29, 2023
View reviewed changes
seanpearsonuk
seanpearsonuk reviewed Nov 29, 2023
View reviewed changes
hpohekar and others added 2 commits November 29, 2023 18:21
@hpohekar @seanpearsonuk
Update src/ansys/fluent/core/launcher/launcher.py
8bd2af0 
Co-authored-by: Sean Pearson <93727996+seanpearsonuk@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c09663b 
for more information, see https://pre-commit.ci
@hpohekar hpohekar enabled auto-merge (squash) November 29, 2023 15:02
@hpohekar hpohekar merged commit 7922254 into main Nov 29, 2023
@hpohekar hpohekar deleted the feat/factory_pattern_launch_fluent branch November 29, 2023 17:22
seanpearsonuk
seanpearsonuk reviewed Dec 12, 2023
View reviewed changes
src/ansys/fluent/core/launcher/launcher.py
if meshing_mode:
session.tui.file.read_case(case_file_name)
elif lightweight_mode:
session.read_case_lightweight(case_file_name)
Copy link
Collaborator

@seanpearsonuk seanpearsonuk Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansjsia @raph-luc to confirm, this is the old version

seanpearsonuk
seanpearsonuk reviewed Dec 12, 2023
View reviewed changes
src/ansys/fluent/core/launcher/standalone_launcher.py
if self.meshing_mode:
session.tui.file.read_case(self.case_file_name)
else:
session.read_case(self.case_file_name, self.lightweight_mode)
Copy link
Collaborator

@seanpearsonuk seanpearsonuk Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansjsia @raph-luc the old version was changed here to this newer version.
I.e. from

elif lightweight_mode:
                    session.read_case_lightweight(case_file_name)
else:
                    session.read_case(case_file_name)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for helping dig this out @seanpearsonuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@prmukherj prmukherj Awaiting requested review from prmukherj prmukherj is a code owner

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

@raph-luc raph-luc Awaiting requested review from raph-luc

+1 more reviewer

@ansaboutin ansaboutin ansaboutin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remote_file_handler is None if we use connect_to_fluent Apply the factory pattern in launch code
5 participants
@hpohekar @seanpearsonuk @mkundu1 @raph-luc @ansaboutin