Transform cached state for display names or internal names

[mkundu1]

The cached state returned from DataModelCache.get_state(rules, obj, name_key) will contain display names or internal names based on the parameter name_key

[seanpearsonuk]

@prmukherj Have you tried this branch out? Is the cached state now coming with display names?

@seanpearsonuk, yes pulled it into my branch and tried it with switching display names on. Working fine.

[mkundu1]

@prmukherj I'll investigate the test failures.

[mkundu1]

Looking at one of the failing test tests/test_data_model_cache.py::test_get_cached_values_in_command_arguments, it seems it now correctly returns the value from the cache. When the cache contains the entry 'TaskObject:TaskObject1': {'TaskList': [], 'InactiveTaskList': [], '_name_': 'Import Geometry', 'Arguments': {'FileName': 'Bob'}, 'CommandName': 'ImportGeometry', 'TaskType': 'Simple', 'ObjectPath': '', 'State': 'Out-of-date'},, which is not changed and we query the state at path TaskObject:Import Geometry/Arguments, it now returns {'FileName': 'Bob'}. Earlier it used to return DataModelCache.Empty. This is probably making a difference that fails the test with these new changes.

[prmukherj]

Thank you @mkundu1 for the input. I'll check this.

[mkundu1]

@prmukherj @seanpearsonuk
Among the remaining failing tests, one type of failure seems to be due to the code queries for TaskList and InactiveTaskList parameters which return internal names. They don't match with the state as the state is received with display names from the cache.
There is another type of failure which I've locally tested to fix by adding some sleep before the assert, e.g. the following assert in tests/test_meshing_workflow.py::test_extended_wrapper:

assert import_geometry.arguments.get_state(explicit_only=True) == dict(
    FileName=None
)

The assert is executed before the cache is updated with the streamed state.

[prmukherj]

@mkundu1, @seanpearsonuk , what should be our approach then? Shall we fix the test along this new behavior? The earlier behavior seems inaccurate then, right?