Skip to content

perf: using MAPDL calls only to get the nodes in coordinate systems#3792

Merged
germa89 merged 5 commits into
mainfrom
perf/improving-performance-of-nodes-in-different-CS
Mar 11, 2025
Merged

perf: using MAPDL calls only to get the nodes in coordinate systems#3792
germa89 merged 5 commits into
mainfrom
perf/improving-performance-of-nodes-in-different-CS

Conversation

@germa89

@germa89 germa89 commented Mar 10, 2025

Copy link
Copy Markdown
Collaborator

Description

As the title, to avoid download and upload an array with (potentially) lots of nodes.

Issue linked

Fix #3764

Checklist

@germa89 germa89 requested a review from a team as a code owner March 10, 2025 19:36
@germa89 germa89 self-assigned this Mar 10, 2025
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the enhancement Improve any current implemented feature label Mar 10, 2025
@codecov

codecov Bot commented Mar 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (8f7b195) to head (5a78abc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3792      +/-   ##
==========================================
- Coverage   88.37%   88.36%   -0.02%     
==========================================
  Files         187      187              
  Lines       14738    14742       +4     
==========================================
+ Hits        13025    13027       +2     
- Misses       1713     1715       +2     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89

germa89 commented Mar 11, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) March 11, 2025 15:13

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 04e9500 into main Mar 11, 2025
@germa89 germa89 deleted the perf/improving-performance-of-nodes-in-different-CS branch March 11, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Low performance code

2 participants