Skip to content

PyWB Cheatsheet reviewed and corrected #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 8, 2025
Merged

PyWB Cheatsheet reviewed and corrected #172

merged 15 commits into from
Jan 8, 2025

Conversation

vnamdeo
Copy link
Contributor

@vnamdeo vnamdeo commented Dec 19, 2024 •
edited by dipinknair
Loading

PyWorkbench Cheatsheet for the review.

@vnamdeo vnamdeo requested a review from a team as a code owner December 19, 2024 12:39
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New features or code improvements labels Dec 19, 2024
@vnamdeo vnamdeo self-assigned this Dec 19, 2024
@vnamdeo vnamdeo changed the title PyWB Cheatsheet reviwed and corrected PyWB Cheatsheet reviewed and corrected Dec 19, 2024
@vnamdeo
Copy link
Contributor Author

vnamdeo commented Dec 20, 2024

@franknli @Revathyvenugopal162 @PipKat: Please review the PyWorkbench Cheatsheet for the further process. Thanks!

PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat reviewed Dec 20, 2024
View reviewed changes
PipKat
PipKat approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several suggestions to bring content into conformance with PyAnsys style guidelines.

@vnamdeo
Copy link
Contributor Author

vnamdeo commented Dec 23, 2024

Several suggestions to bring content into conformance with PyAnsys style guidelines.

Thanks @PipKat Modified it as per the suggestions. Please review it and let me know if you have further suggestions as per the PyAnsys style guidelines. Thanks!

@vnamdeo
Copy link
Contributor Author

vnamdeo commented Jan 7, 2025

Several suggestions to bring content into conformance with PyAnsys style guidelines.

Thanks @PipKat Modified it as per the suggestions. Please review it and let me know if you have further suggestions as per the PyAnsys style guidelines. Thanks!

@PipKat Kindly confirm it. Accordingly, I will merge the PR with the main. Thanks!

PipKat
PipKat reviewed Jan 7, 2025
View reviewed changes
PipKat
PipKat reviewed Jan 7, 2025
View reviewed changes
PipKat
PipKat reviewed Jan 7, 2025
View reviewed changes
PipKat
PipKat reviewed Jan 7, 2025
View reviewed changes
PipKat
PipKat reviewed Jan 7, 2025
View reviewed changes
PipKat
PipKat reviewed Jan 7, 2025
View reviewed changes
PipKat
PipKat reviewed Jan 7, 2025
View reviewed changes
PipKat
PipKat approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vnamdeo Minor nitpicks with explanations where appropriate. Nice job! This PR was out of date with the main branch, so I merged it. It seems that the code style failure has to do with adding license headers.

@github-actions github-actions bot added the testing Anything related to tests label Jan 8, 2025
@dipinknair dipinknair merged commit cb90782 into main Jan 8, 2025
28 checks passed
@dipinknair dipinknair deleted the feat/updates-pyworkbench-cheatsheet branch January 8, 2025 15:17
@dipinknair dipinknair restored the feat/updates-pyworkbench-cheatsheet branch January 8, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipinknair dipinknair dipinknair approved these changes

@PipKat PipKat PipKat approved these changes

@franknli franknli Awaiting requested review from franknli

@Revathyvenugopal162 Revathyvenugopal162 Awaiting requested review from Revathyvenugopal162

Assignees

@vnamdeo vnamdeo

Labels
documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vnamdeo @dipinknair @PipKat @pyansys-ci-bot