Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onPanelChange in RangerPicker never trigger #22142

Closed
1 task done
narrowizard opened this issue Mar 12, 2020 · 3 comments
Closed
1 task done

onPanelChange in RangerPicker never trigger #22142

narrowizard opened this issue Mar 12, 2020 · 3 comments
Labels
3.x 3.x stable issue or bug fix, PR should be cherry-pick to master help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@narrowizard
Copy link

narrowizard commented Mar 12, 2020 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. select date from range picker, then click select time

What is expected?

onPanelChange should be trigger, and print log on console.

What is actually happening?

onPanelChange is not trigger

Environment Info
antd 3.26.13
React 16.13.0
System Windows 10
Browser Google Chrome 80.0.3987.132

onPanelChange in DatePicker behaves correctly.
@zombieJ zombieJ added 3.x 3.x stable issue or bug fix, PR should be cherry-pick to master help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Mar 12, 2020
@ant-design-bot
Copy link
Contributor

Hello @narrowizard. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @narrowizard, 我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支（新特性发到 feature 分支，其他发到 master 分支），务必填写 Pull Request 内的预设模板，提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！

giphy

narrowizard added a commit to narrowizard/calendar that referenced this issue Mar 17, 2020
@narrowizard
fixes ant-design/ant-design#22142
d1491e7
@narrowizard
Copy link
Author

narrowizard commented Mar 17, 2020 •
edited

i have created a pull request on rc-calendar repo, please take a look at it. @zombieJ
react-component/calendar#656

@zombieJ zombieJ added 3.x 3.x stable issue or bug fix, PR should be cherry-pick to master and removed 3.x 3.x stable issue or bug fix, PR should be cherry-pick to master labels Feb 20, 2023
@github-actions
Copy link
Contributor

Hi @narrowizard. Current version (3.x) is off the maintenance period. We may not accept pull request or fix bug with it anymore. This topic will be auto closed.

你好 @narrowizard，当前版本（3.x）已经过了维护期。我们不会再接受对其的相关 PR 与 issue。当前 topic 会被自动关闭。

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x 3.x stable issue or bug fix, PR should be cherry-pick to master help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zombieJ @narrowizard @ant-design-bot