Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Azerbaijani translation #21341

Closed
wants to merge 32 commits into from

Conversation

orkhan-huseyn
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Added Azerbaijani translation into locale provider

💡 Background and solution

Added Azerbaijani translation into locale provider

📝 Changelog

Added Azerbaijani translation into locale provider

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@orkhan-huseyn orkhan-huseyn changed the title add Azerbaijani translation feat: add Azerbaijani translation Feb 11, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 11, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 70b8fb2:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3d9efbe:

Sandbox Source
antd reproduction template Configuration

Copy link
Contributor

@yoyo837 yoyo837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components/locale-provider/az_AZ.tsx:

import locale from '../locale/az_AZ';

export default locale;

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 08d16e6:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #21341 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21341   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         300      300           
  Lines        7003     7003           
  Branches     1884     1931   +47     
=======================================
  Hits         6832     6832           
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5425d84...440bb77. Read the comment docs.

shaodahong and others added 4 commits February 12, 2020 10:50
…gn#21222)

* fix(Form): label width not correct when screen less than xs

* fix form item control width

* fix css selector priority
…gn#21222)

* fix(Form): label width not correct when screen less than xs

* fix form item control width

* fix css selector priority
@orkhan-huseyn
Copy link
Contributor Author

Hi,
I have added az_AZ locale to rc-picker library and it has been merged.
Why am I getting this error on Circle CI?

components/date-picker/locale/az_AZ.tsx:1:28 - error TS2307: Cannot find module 'rc-picker/lib/locale/az_AZ'.

1 import CalendarLocale from 'rc-picker/lib/locale/az_AZ';

@yoyo837
Copy link
Contributor

yoyo837 commented Feb 12, 2020

rc-picker has not released a new version

@orkhan-huseyn
Copy link
Contributor Author

I have added the same locales to rc-pagination as well. And it has been merged into master.

@yoyo837
Copy link
Contributor

yoyo837 commented Feb 12, 2020

Also not released yet

@orkhan-huseyn
Copy link
Contributor Author

Hi, when do we know that the depended packages are released new version?
Also, what should I do about commits? I already have 8 commits for a simple feature.

@yoyo837
Copy link
Contributor

yoyo837 commented Feb 14, 2020

Your commits is mixed with other people's changes.

About dependent new version, you can watch its release.

image

@orkhan-huseyn
Copy link
Contributor Author

That's because I have fethced and rebased before pushing. What should I do about them?

@yoyo837
Copy link
Contributor

yoyo837 commented Feb 14, 2020

You can try rebase again.

@zombieJ
Copy link
Member

zombieJ commented Feb 14, 2020

+ rc-picker@0.0.1-rc.6

@yoyo837
Copy link
Contributor

yoyo837 commented Feb 15, 2020

I think you may need to send a new PR, please remember to pull the latest changes from upstream before that.

@orkhan-huseyn
Copy link
Contributor Author

Alright. I am closing this PR then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants