Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: menu component token #43576

Merged
merged 9 commits into from
Jul 17, 2023
Merged

refactor: menu component token #43576

merged 9 commits into from
Jul 17, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jul 15, 2023

  • docs: update examples link
  • refacor: menu component token

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Migrate Component Token of Menu from 4.x less variables.
🇨🇳 Chinese 补全 Menu 的组件 token。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at ea38a8f

This pull request introduces new style tokens and refactors the existing style functions for the menu component to enable more customization and consistency. It also updates the documentation to reflect the changes and fixes the DOCTYPE declaration in the blog posts.

🔍 Walkthrough

🤖 Generated by Copilot at ea38a8f

  • Rename menuHorizontalHeight to horizontalLineHeight and menuItemPaddingInline to itemPaddingInline for clarity and consistency (link, link, link, link, link, link, link, link, link)
  • Add groupTitleLineHeight and groupTitleFontSize tokens to customize group title style in Menu component (link, link, link, link, link, link)
  • Add itemHeight, collapsedWidth, popupBg, itemMarginBlock, horizontalLineHeight, iconSize, iconMarginInlineEnd, collapsedIconSize, and dark theme tokens to customize Menu component in different modes, themes, and states (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Remove unused or replaced tokens from genMenuItemStyle, getBaseStyle, and genComponentStyleHook functions (link, link, link, link)
  • Change DOCTYPE declaration from uppercase to lowercase in extract-ssr.en-US.md and extract-ssr.zh-CN.md documents to follow HTML5 standard (link, link)

@stackblitz
Copy link

stackblitz bot commented Jul 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 381.58 KB (+273 B 🔺)
./dist/antd-with-locales.min.js 441.22 KB (+283 B 🔺)

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3847462) 100.00% compared to head (9cad921) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #43576    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          657       657            
  Lines        11223     11085   -138     
  Branches      3055      3013    -42     
==========================================
- Hits         11223     11085   -138     
Impacted Files Coverage Δ
components/menu/style/horizontal.tsx 100.00% <ø> (ø)
components/menu/style/theme.tsx 100.00% <ø> (ø)
components/menu/style/vertical.tsx 100.00% <ø> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@argos-ci
Copy link

argos-ci bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Jul 17, 2023, 1:59 AM

@MadCcc
Copy link
Member Author

MadCcc commented Jul 17, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 1 change Jul 17, 2023, 1:59 AM

Expected

@MadCcc MadCcc merged commit 74c7d20 into master Jul 17, 2023
@MadCcc MadCcc deleted the refactor/menu-token branch July 17, 2023 02:13
@afc163
Copy link
Member

afc163 commented Jul 17, 2023

这个不应该合并到 master 分支。

@MadCcc MadCcc mentioned this pull request Aug 9, 2023
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants