Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Notification RTL should have corrent margin #45386

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Oct 17, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45384

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Notification's incorrect margin in rtl mode.
🇨🇳 Chinese 修复 Notification 组件在 rtl 模式下边缘间距错误的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 325849c

This pull request improves the notification component's responsiveness and cross-browser compatibility. It adjusts the component's style and placement using CSS properties that work well on different screen sizes, orientations, and languages. It also removes some unused or problematic code from components/notification/style/placement.ts and components/notification/style/index.ts.

🔍 Walkthrough

🤖 Generated by Copilot at 325849c

  • Replace logical properties with physical ones for notification component (link, link)
  • Remove empty code block from components/notification/style/placement.ts (link)

@stackblitz
Copy link

stackblitz bot commented Oct 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 397.92 KB (+14 B 🔺)
./dist/antd-with-locales.min.js 457.23 KB (+13 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 17, 2023, 8:33 AM

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fc5abff) 100.00% compared to head (325849c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45386   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          694       694           
  Lines        11674     11674           
  Branches      3117      3117           
=========================================
  Hits         11674     11674           
Files Coverage Δ
components/notification/style/index.ts 100.00% <ø> (ø)
components/notification/style/placement.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang merged commit 7ceb1fb into master Oct 17, 2023
97 checks passed
@kiner-tang kiner-tang deleted the fix/notification-margin branch October 17, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong margin in RTL notification
3 participants