Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Descriptions): style bordered table overflow #49946

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

leefinder
Copy link
Contributor

@leefinder leefinder commented Jul 18, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image
image

📝 Changelog

  • Use a developer-oriented tone and narrative style.
  • Describe the user's first-hand experience of the issue and its impact on developers, rather than your solution approach.
  • Refer to: https://ant.design/changelog
Language Changelog
🇺🇸 English 💄 Fixed the issue where the table element style overflows the view container in bordered mode.
🇨🇳 Chinese 💄 修复bordered模式下,table元素样式溢出view容器的问题

Copy link

stackblitz bot commented Jul 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jul 18, 2024

👁 Visual Regression Report for PR #49946 Failed ❌

🎯 Target branch: master (87fb6de)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
descriptions-component-token.compact.png descriptions-component-token.compact.png descriptions-component-token.compact.png descriptions-component-token.compact.png
descriptions-component-token.compact.png descriptions-component-token.compact.png descriptions-component-token.compact.css-var.png descriptions-component-token.compact.css-var.png
descriptions-component-token.dark.png descriptions-component-token.dark.png descriptions-component-token.dark.png descriptions-component-token.dark.png
descriptions-component-token.dark.png descriptions-component-token.dark.png descriptions-component-token.dark.css-var.png descriptions-component-token.dark.css-var.png
descriptions-component-token.default.png descriptions-component-token.default.png descriptions-component-token.default.png descriptions-component-token.default.png
descriptions-component-token.default.png descriptions-component-token.default.png descriptions-component-token.default.css-var.png descriptions-component-token.default.css-var.png
descriptions-style.compact.png descriptions-style.compact.png descriptions-style.compact.png descriptions-style.compact.png
descriptions-style.compact.png descriptions-style.compact.png descriptions-style.compact.css-var.png descriptions-style.compact.css-var.png
descriptions-style.dark.png descriptions-style.dark.png descriptions-style.dark.png descriptions-style.dark.png
descriptions-style.dark.png descriptions-style.dark.png descriptions-style.dark.css-var.png descriptions-style.dark.css-var.png

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Preview is ready

Copy link

pkg-pr-new bot commented Jul 18, 2024

commit: 67c455a

antd

npm i https://pkg.pr.new/ant-design/ant-design/antd@49946


templates

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@290d10c). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #49946   +/-   ##
=========================================
  Coverage          ?   99.99%           
=========================================
  Files             ?      749           
  Lines             ?    13063           
  Branches          ?     3405           
=========================================
  Hits              ?    13062           
  Misses            ?        1           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 2efbdbf into ant-design:master Jul 20, 2024
54 checks passed
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

afc163 added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants