-
-
Notifications
You must be signed in to change notification settings - Fork 49.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(useLocale): make component locale overriding locale from con… #50213
Conversation
Run & review this pull request in StackBlitz Codeflow. |
|
Please create a online reproduce and describe what problem this PR you want to resolve? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a online reproduce and describe what problem this PR you want to resolve?
commit:
|
Sorry i will make all change you talk about |
f25704c
to
7fb7e06
Compare
Hello @afc163 , I've updated my code to be clearer and not to cause any breaking changes. |
I finally noticed that the problem was with Calendar and not the other components, so I opened a PR to fix it. Sorry for the inconvenience. We can close this. |
Here the new PR: #50236 |
…text
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Today, if I inject parameters into the
locale
props in my Calendar component, it doesn't take them into account if I already have alocale
in my ConfigProvider. This means that I can't have a global configuration that I override for specific cases. Here some exemple : https://stackblitz.com/edit/react-o7hv5j?file=demo.tsxYou can see that if you remove ConfigProvider locale, all we work fine
📝 Changelog