Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mongodb URI issue #5393

Merged
merged 11 commits into from
Aug 14, 2023
Merged

Fix Mongodb URI issue #5393

merged 11 commits into from
Aug 14, 2023

Conversation

USAMAWIZARD
Copy link
Contributor

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 24, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@mekya mekya changed the title fix Mogodb URI issue Fix Mongodb URI issue Jul 31, 2023
@mekya
Copy link
Contributor

mekya commented Jul 31, 2023

Hi @USAMAWIZARD,

Thank you very much for the fix. I'm gently reminding you the test code.

If we have the test code, we'll make sure that we don't have the same problem again in the same way and it serves the following principle in the manifesto

Solve problems permanently. Don’t waste time addressing the same issue multiple times.

@USAMAWIZARD
Copy link
Contributor Author

Thanks @mekya abi I will try to implement the test cases.

@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.15.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@USAMAWIZARD
Copy link
Contributor Author

USAMAWIZARD commented Aug 13, 2023

Test Cases has been Added

Copy link
Contributor

@mekya mekya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @USAMAWIZARD 👏

In this way, we'll make sure that we won't encounter the same problem again. So we spend our time on things that has an impact/results ;)

@mekya mekya merged commit 1f2a7c5 into master Aug 14, 2023
3 checks passed
@mekya mekya deleted the fix_uri_issue branch August 14, 2023 07:35
@USAMAWIZARD
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants