Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve compatibility with noPropertyAccessFromIndexSignature #145

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

zanminkian
Copy link
Contributor

@zanminkian zanminkian commented Dec 21, 2022

Description

Ts project, which enabled noPropertyAccessFromIndexSignature, will have conflict with dot-notation.

Line 36 has enabled @typescript-eslint/dot-notation. So, we can disable dot-notation in ts file. People who want to enable dot-notation can enable type aware rules by adding tsconfig.eslint.json file.

Linked Issues

Additional context

@zanminkian
Copy link
Contributor Author

Don't have perfect method to solve the conflict with noPropertyAccessFromIndexSignature. Any suggestions will help this project out-of-box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants