Proposed changed to update punycode

[urizennnn]

I just did yarn add punycode and changed dependencies that require punycode to fix #365

[dgellow]

Hi @urizennnn. Unfortunately I do not think that would be enough. The problem here is that require("punycode") imports the punycode node core library that has been deprecated. whatwg-url, a dependency of node-fetch does that import. Even if we add punycode explicitly the core library would still be the one being imported.

To get rid of the warning we would either need to replace node-fetch (the work would be similar to what is done with openai/openai-node#402), or have users of the sdk patch require("punycode") in whatwg-url to become require("punycode/") (using a patch utility such as https://github.com/ds300/patch-package?tab=readme-ov-file).

[urizennnn]

Hi @urizennnn. Unfortunately I do not think that would be enough. The problem here is that require("punycode") imports the punycode node core library that has been deprecated. whatwg-url, a dependency of node-fetch does that import. Even if we add punycode explicitly the core library would still be the one being imported.

To get rid of the warning we would either need to replace node-fetch (the work would be similar to what is done with openai/openai-node#402), or patch require("punycode") in whatwg-url to become require("punycode/").

oh ok, so are there any temporal fixes available atm?

[rattrayalex]

In the short term, you can work around this by overriding the dependency in your package.json, eg:

"overrides": {
  "whatwg-url": "13.0.0"
}

[urizennnn]

In the short term, you can work around this by overriding the dependency in your package.json, eg:

"overrides": {
  "whatwg-url": "13.0.0"
}

Considering my case that won't work since I am not running the code in native js (not sure that is the right way to explain but yh), it being ran from a lua file so i'm not sure it would fix that but i just added the --no-deprecation flag to it