Fixed test file, added alternative sentence maker #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fixed usage of `number` in tests (it takes one arg, not two) 2) Added `sentence_actual`, which returns an actual sentence from the Sherlock text. 3) Added `_picka._Book` class to hold the text and split sentences read from Sherlock. Users can call sentence() without reading the entire file again and again. 4) Added test of `sentence_actual` to `picka.tests`
ghost
assigned 
1) General cleanup of supporting stuff around `sentence` and `sentence_actual` 2) Improved the way sentences are split into words and filtered 3) No longer using `random.shuffle` to yield a random sentence. `random.randint` + list indexing is many times faster. 4) Added docstrings for `sentence` and `sentence_actual`
antlong
added a commit
that referenced
this pull request
Jan 17, 2014
Fixed test file, added alternative sentence maker
|
Thank you for contributing to picka. I appreciate it very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numberin tests (it takes one arg, not two)sentence_actual, which returns an actual sentence from the Sherlock text._picka._Bookclass to hold the text and split sentences read from Sherlock.Users can call sentence() without reading the entire file again and again.
sentence_actualtopicka.testsThe
sentence_actualfunction has some nice features:cached by the
_Bookclass.The sentences aren't always perfect, but I think that has to do with the source. A book other than Sherlock Holmes, preferably one with less dialog, would give more "normal" sentences.