This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Add Support for Java 8u171/172 #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah great, already been done. It's that time of year again... merge ASAP please, and update release on the forge... |
|
"This JRE (version 8u172) will expire with the release of the next critical patch update scheduled for July 17, 2018" so make a note in your diaries... would be nice if we could get the next version released to the forge in advance of the expiry date... |
antoineco
suggested changes
Apr 20, 2018
manifests/init.pp
Outdated
|
|
||
| # define package name | ||
| if versioncmp($version_final, '8u151') >= 0 and $maj_version != '9' { | ||
| if versioncmp($version_final, '8u172') >= 0 and $maj_version != '9' { |
There was a problem hiding this comment.
Will break all versions below 8u172, please revert this particular change.
antoineco
approved these changes
Apr 23, 2018
Repository owner
deleted a comment from
mtron
Apr 23, 2018
|
Thanks @mtron! 🙌 |
|
Released in v2.9.4 |
|
Many thanks to you both👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.