Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set folder names matching names of components on diagram #22

Closed
antonbabenko opened this issue Mar 11, 2020 · 7 comments
Closed

Set folder names matching names of components on diagram #22

antonbabenko opened this issue Mar 11, 2020 · 7 comments

Comments

@antonbabenko
Copy link
Owner

Is your feature request related to a problem? Please describe.

Names of folders are confusing - rds_1, security-group_1...

Describe the solution you'd like

Use names from components, replace strange characters with single _

Additional context

cloudcraft-proposal-naming

@antonbabenko
Copy link
Owner Author

@Genaker This was way easier than I expected, fixed and deployed.

Thanks for the feedback!

@Genaker
Copy link

Genaker commented Mar 22, 2020 via email

@Genaker
Copy link

Genaker commented Mar 24, 2020

It can be an issue. I didn't try to run it but

dependency "aws-data" {
  config_path = "../aws-data"
}

dependency "Production-VPC" {
  config_path = "../Production-VPC"
}

dependency "SSH22-SecurityGroup" {
  config_path = "../SSH22-SecurityGroup"
}

dependency "WebNode-LoadBalancer" {
  config_path = "../WebNode-LoadBalancer"
}

where folder actually is lowercased

Possible solutions:

  1. Lowercase this part of code generation also

config_path = "../webnode-loadnalancer"

  1. Don't lowercase the names of the folders

@antonbabenko
Copy link
Owner Author

Fixed in 6d21738 by lowercasing directory name.

@Genaker
Copy link

Genaker commented Mar 24, 2020 via email

@Genaker
Copy link

Genaker commented Mar 25, 2020

I'm also thinking root folder has name of region (us-west-1). Maybe it is better to name it by VPC name (production)?

@antonbabenko
Copy link
Owner Author

No, resources are grouped according to public cloud provider model (AWS account => region (or global) => resource)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants