Release 1.6.0 #3531

tnqn · 2022-03-28T17:21:12Z

Signed-off-by: Quan Tian qtian@vmware.com

tnqn · 2022-03-28T17:28:15Z

CHANGELOG/CHANGELOG-1.6.md

+  * Add ServiceAccount selector in Antrea-native policies to allow selecting Pods by ServiceAccount. ([#3044](https://github.com/antrea-io/antrea/pull/3044), [@GraysonWu])
+  * Support Pagination for ClusterGroupMembership. ([#3183](https://github.com/antrea-io/antrea/pull/3183), [@qiyueyao])
+  * Add Port Number to Audit Logging. ([#3277](https://github.com/antrea-io/antrea/pull/3277), [@qiyueyao])
+- [Flow Visibility] Add support for exporting flow records to ClickHouse. ([#3196](https://github.com/antrea-io/antrea/pull/3196) [#3498](https://github.com/antrea-io/antrea/pull/3498) [#3244](https://github.com/antrea-io/antrea/pull/3244) [#3063](https://github.com/antrea-io/antrea/pull/3063) [#3312](https://github.com/antrea-io/antrea/pull/3312), [@wsquan171] [@yanjunz97] [@zyiou] [@dreamtalen])


@antoninbas @salv-orlando @wsquan171 @yanjunz97 @dreamtalen please correct me or add more details if the description is not accurate for what we did in 1.6.

Thanks Quan, I'm going to add some details here:
`

[Flow Visibility] Add Grafana Flow Collector as the new visualization tool for flow records.

Add Grafana dashboards, Clickhouse data schema, deployment files, and doc. [[Flow Visibility] Add Grafana and Clickhouse deployment file #3063][Refactor Grafana and ClickHouse deployment configuration instructions #3525] @heanlan @zyiou @dreamtalen

Add support for exporting flow records to ClickHouse from Flow Aggregator. [Add ClickHouse Client #3196][Update generate-manifest-flow-aggregator.sh with new config #3526] @wsquan171 @dreamtalen

Add ClickHouse monitor to ensure data retention for in-memory ClickHouse deployment [[Flow Visibility] Add data retention methods for in-memory Clickhouse deployment #3244][Refactor ClickHouse monitor implementation #3498] @yanjunz97

Add CI validation job for Flow Visibility deployment [[Flow Visibility] Add CI validation job for flow visibility depolyment files #3312]@dreamtalen

`
cc. @heanlan to review this too.

Done, but removed the 4th item as it's not user facing.

Looks good to me. Thanks @dreamtalen for the feedback.

tnqn · 2022-03-28T17:29:34Z

Create the PR for review, will update the target branch to release-1.6 and add a commit to update VERSION once the remaining PRs are merged.

CHANGELOG/CHANGELOG-1.6.md

tnqn · 2022-03-28T18:16:31Z

Thanks @jianjuns @dreamtalen. Addressed your comments.

antoninbas

this is a massive release!

CHANGELOG/CHANGELOG-1.6.md

tnqn · 2022-03-29T02:51:24Z

Thanks @antoninbas. Addressed your comments.

tnqn · 2022-03-29T02:54:54Z

/test-whole-conformance
/skip-conformance
/test-networkpolicy
/test-e2e
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-multicast-e2e
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all

codecov-commenter · 2022-03-29T04:12:44Z

Codecov Report

Merging #3531 (b8d288e) into release-1.6 (77f8709) will increase coverage by 10.77%.
The diff coverage is n/a.

❗ Current head b8d288e differs from pull request most recent head f810560. Consider uploading reports for the commit f810560 to get more accurate results

@@               Coverage Diff                @@
##           release-1.6    #3531       +/-   ##
================================================
+ Coverage        43.36%   54.13%   +10.77%     
================================================
  Files              210      392      +182     
  Lines            25226    53479    +28253     
================================================
+ Hits             10939    28953    +18014     
- Misses           13197    22035     +8838     
- Partials          1090     2491     +1401

Flag	Coverage Δ
e2e-tests	`49.47% <ø> (?)`
integration-tests	`38.21% <ø> (?)`
kind-e2e-tests	`51.26% <ø> (?)`
unit-tests	`43.38% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/controller/networkpolicy/endpoint_querier.go	`61.46% <0.00%> (-29.97%)`	⬇️
pkg/controller/ipam/antrea_ipam_controller.go	`44.89% <0.00%> (-29.24%)`	⬇️
pkg/util/sets/string.go	`75.00% <0.00%> (-25.00%)`	⬇️
pkg/controller/ipam/validate.go	`57.95% <0.00%> (-24.31%)`	⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go	`56.66% <0.00%> (-23.34%)`	⬇️
pkg/controller/networkpolicy/clustergroup.go	`54.14% <0.00%> (-22.75%)`	⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go	`57.24% <0.00%> (-22.55%)`	⬇️
pkg/agent/util/iptables/lock.go	`60.00% <0.00%> (-21.82%)`	⬇️
pkg/controller/externalippool/validate.go	`55.17% <0.00%> (-21.02%)`	⬇️
pkg/controller/egress/controller.go	`67.84% <0.00%> (-20.60%)`	⬇️
... and 352 more

antoninbas

LGTM

salv-orlando

Release notes LGTM. Just some nits inline - that don't need to be addressed.

salv-orlando · 2022-03-29T06:47:05Z

CHANGELOG/CHANGELOG-1.6.md

+- Fix pkt mark conflict between HostLocalSourceMark and SNATIPMark. ([#3430](https://github.com/antrea-io/antrea/pull/3430), [@tnqn])
+- Unconditionally sync CA cert for Controller webhooks to fix Egress support when AntreaPolicy is disabled. ([#3421](https://github.com/antrea-io/antrea/pull/3421), [@antoninbas])
+- Fix inability to access NodePort in particular cases. ([#3371](https://github.com/antrea-io/antrea/pull/3371), [@hongliangl])
+- Fix ipBlocks referenced in nested ClusterGroup were not processed correctly. ([#3383](https://github.com/antrea-io/antrea/pull/3383), [@Dyanngg])


pedant nit: "were" in the sentence above seems redundant

I also thought this is not needed, added it according Jianjun's comment. Removed it now. @jianjuns please let us know if you believe it's needed.

salv-orlando · 2022-03-29T06:48:22Z

CHANGELOG/CHANGELOG-1.6.md

+- Add userspace ARP/NDP responders to fix Egress and ServiceExternalIP support for IPv6 clusters. ([#3318](https://github.com/antrea-io/antrea/pull/3318), [@hty690])
+- Fix incorrect results by `antctl get networkpolicy` when both Pod and Namespace are specified. ([#3499](https://github.com/antrea-io/antrea/pull/3499), [@Dyanngg])
+- Fix IP leak issue when AntreaIPAM is enabled. ([#3314](https://github.com/antrea-io/antrea/pull/3314), [@gran-vmv])
+- Fix error when dumping OVS flows of a NetworkPolicy via `antctl get ovsflows`. ([#3335](https://github.com/antrea-io/antrea/pull/3335), [@jainpulkit22])


pedant nit: consider replacing "of a" with "for a"

salv-orlando · 2022-03-29T06:54:19Z

CHANGELOG/CHANGELOG-1.6.md

+- [Multicast] Support IGMPv3 leave action. ([#3389](https://github.com/antrea-io/antrea/pull/3389), [@wenyingd])
+- [Windows] Add support for EndpointSlices on Windows Nodes. ([#3321](https://github.com/antrea-io/antrea/pull/3321), [@XinShuYang])
+- Add SKIP_CNI_BINARIES environment variable to support skipping the installation of specified CNI plugins. ([#3454](https://github.com/antrea-io/antrea/pull/3454), [@jainpulkit22])
+- Support UBI8-based container image to run Antrea. ([#3273](https://github.com/antrea-io/antrea/pull/3273), [@ksamoray])


nit: The above can be tagged with [Openshift] Since UBI8 images are specifically used for that distro (in theory you can use them anywhere, but in Openshift you can only use them)

Signed-off-by: Quan Tian <qtian@vmware.com>

tnqn · 2022-03-29T12:15:12Z

/test-whole-conformance
/skip-conformance
/test-networkpolicy
/test-e2e
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-multicast-e2e
/test-windows-all
/test-ipv6-all
/test-ipv6-only-all

tnqn · 2022-03-29T13:20:50Z

/test-all-features-conformance

tnqn · 2022-03-29T13:20:59Z

/test-hw-offload

tnqn · 2022-03-29T14:17:55Z

/test-e2e

tnqn · 2022-03-29T15:01:20Z

/test-ipv6-only-conformance

tnqn · 2022-03-29T15:53:21Z

/test-ipv6-only-conformance

tnqn requested review from salv-orlando, antoninbas and jianjuns March 28, 2022 17:21

tnqn commented Mar 28, 2022

View reviewed changes

jianjuns reviewed Mar 28, 2022

View reviewed changes

tnqn force-pushed the release-1.6.0 branch from 94fa05d to 9ea2194 Compare March 28, 2022 18:15

tnqn force-pushed the release-1.6.0 branch 2 times, most recently from 008ca23 to 9b0ae34 Compare March 28, 2022 18:23

antoninbas reviewed Mar 28, 2022

View reviewed changes

tnqn force-pushed the release-1.6.0 branch from 9b0ae34 to b8d288e Compare March 29, 2022 02:49

tnqn changed the base branch from main to release-1.6 March 29, 2022 02:50

tnqn marked this pull request as ready for review March 29, 2022 02:50

jianjuns approved these changes Mar 29, 2022

View reviewed changes

antoninbas approved these changes Mar 29, 2022

View reviewed changes

salv-orlando reviewed Mar 29, 2022

View reviewed changes

tnqn added 2 commits March 29, 2022 20:03

Update CHANGELOG for v1.6.0 release

cb3910b

Signed-off-by: Quan Tian <qtian@vmware.com>

Set VERSION to v1.6.0

f810560

Signed-off-by: Quan Tian <qtian@vmware.com>

tnqn force-pushed the release-1.6.0 branch from b8d288e to f810560 Compare March 29, 2022 12:03

tnqn merged commit 7a79389 into antrea-io:release-1.6 Mar 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.6.0 #3531

Release 1.6.0 #3531

tnqn commented Mar 28, 2022

tnqn Mar 28, 2022

dreamtalen Mar 28, 2022

tnqn Mar 28, 2022

salv-orlando Mar 29, 2022

tnqn commented Mar 28, 2022

tnqn commented Mar 28, 2022

antoninbas left a comment

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

codecov-commenter commented Mar 29, 2022 •

edited

Loading

antoninbas left a comment

salv-orlando left a comment

salv-orlando Mar 29, 2022

tnqn Mar 29, 2022

salv-orlando Mar 29, 2022

tnqn Mar 29, 2022

salv-orlando Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

Release 1.6.0 #3531

Release 1.6.0 #3531

Conversation

tnqn commented Mar 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tnqn commented Mar 28, 2022

tnqn commented Mar 28, 2022

antoninbas left a comment

Choose a reason for hiding this comment

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

codecov-commenter commented Mar 29, 2022 • edited Loading

Codecov Report

antoninbas left a comment

Choose a reason for hiding this comment

salv-orlando left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

tnqn commented Mar 29, 2022

codecov-commenter commented Mar 29, 2022 •

edited

Loading