Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(g-canvas & g-svg): add getTotalLength method for path #307

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

dengfuping
Copy link
Member

@dengfuping dengfuping commented Dec 11, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 🌟 [g-canvas & g-svg] Add getTotalLength() method for Path. #295
🇨🇳 Chinese 🌟 [g-canvas & g-svg] Path 上新增 getTotalLength() 成员方法。#295

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Dec 11, 2019

Deploy preview for antv-g ready!

Built with commit 016af32

https://deploy-preview-307--antv-g.netlify.com

@todo
Copy link

todo bot commented Dec 11, 2019

这个 case 与 Canavs 的计算结果误差较大,问题原因待排查

https://github.com/antvis/g/blob/1329242ce2dfb4c75e95d8db4a8a0085f084eee3/packages/g-svg/tests/unit/shape/path-spec.js#L110-L115


This comment was generated by todo based on a TODO comment in 1329242 in #307. cc @antvis.

@dengfuping dengfuping merged commit c964247 into master Dec 11, 2019
@dengfuping dengfuping deleted the fix-issue-295 branch December 11, 2019 10:57
openwayne pushed a commit to openwayne/g that referenced this pull request Jan 18, 2021
feat(g-canvas & g-svg): add getTotalLength method for path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant