New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace @antv/util with lodash-es #894 #968

Merged

xiaoiver merged 2 commits into next from fix-894

May 4, 2022

Contributor

xiaoiver commented May 3, 2022 •

edited

Loading

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed


          fix: replace @antv/util with lodash-es #894

7af93ff

Contributor

github-actions bot commented May 3, 2022 •

edited

Loading

🎊 PR Preview b8e12af has been successfully built and deployed to https://antvis-g-preview-pr-968.surge.sh?type=diff&date=2022-05-04

🕐 Build time: 124.432s

_{🤖 By Surge Ui Insight}


          fix: use setViewOffset when picking in g-webgl to enhance perf #948

b8e12af

Contributor

lgtm-com bot commented May 4, 2022

This pull request introduces 1 alert when merging b8e12af into f01a32e - view on LGTM.com

new alerts:

1 for Unneeded defensive code

coveralls commented May 4, 2022

Pull Request Test Coverage Report for Build 2269070214

10 of 11 (90.91%) changed or added relevant lines in 8 files are covered.
15 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.3%) to 70.261%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/g/src/camera/Camera.ts	3	4	75.0%

Files with Coverage Reduction	New Missed Lines	%
packages/g/src/camera/Camera.ts	15	79.36%

Totals
Change from base Build 2263219947:	0.3%
Covered Lines:	5384
Relevant Lines:	7025

💛 - Coveralls

xiaoiver merged commit 2f17c0d into next

xiaoiver deleted the fix-894 branch

May 4, 2022 12:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet