优化 label 类以及修复相关 BUG #2143
Merged
优化 label 类以及修复相关 BUG #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 4 alerts when merging e03dcc0 into d1b7606 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging f980668 into fdf485c - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 9c7f2a4 into fdf485c - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging 5c43872 into 4b97895 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging 8e811a4 into 4b97895 - view on LGTM.com new alerts:
|
visiky
reviewed
Mar 19, 2020
simaQ
force-pushed
the
label-refactor
branch
2 times, most recently
from
b2b8cca
to
0d4d582
Compare
|
This pull request introduces 3 alerts when merging ac4f3f4 into 394d8e8 - view on LGTM.com new alerts:
|
visiky
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Pie label 的布局调整从 PieGeometryLabel 类逻辑中抽离，使用 label 布局函数实现
refactor: Label 基类添加 layout 默认布局
将 LabelRender 的生成移至 GeometryLabel 的 render 方法中，由 GeometryLabel 统一负责生成 label 信息以及渲染图形。
修复漏斗图相关 bug:
* 更新时 label 位置错误
* 尖底漏斗图最后一个图形 label 定位问题 Closed 尖底漏斗图, 最后一个label位置计算错误 #1847
测试用例修改 + 补充