Skip to content
This repository was archived by the owner on Oct 7, 2023. It is now read-only.

Conversation

Aarebecca
Copy link
Contributor

image
image
image
image
image

支持交互:

  • 拖拽
  • 刷选

支持自定义手柄图标
支持纵向模式

@coveralls
Copy link

coveralls commented Jul 6, 2021

Pull Request Test Coverage Report for Build 1008086463

  • 178 of 232 (76.72%) changed or added relevant lines in 4 files are covered.
  • 56 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-2.5%) to 80.174%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ui/slider/index.ts 173 227 76.21%
Files with Coverage Reduction New Missed Lines %
src/ui/marker/index.ts 1 92.86%
src/ui/icon/index.ts 5 82.76%
src/ui/sparkline/index.ts 5 88.07%
src/ui/button/index.ts 16 71.6%
src/ui/scrollbar/index.ts 29 68.14%
Totals Coverage Status
Change from base Build 1004114834: -2.5%
Covered Lines: 646
Relevant Lines: 772

💛 - Coveralls

@hustcc
Copy link
Member

hustcc commented Jul 7, 2021

额外的一些问题:

  1. sparkline 的 y 轴 scale 可以留一下余量,这样最大值不会顶着头,最小值顶着底,相对会好看一些吧?
  2. 滑块、滑道的高度,会随着组件设置的 height 自动适配吧?

@Aarebecca
Copy link
Contributor Author

额外的一些问题:

  1. sparkline 的 y 轴 scale 可以留一下余量,这样最大值不会顶着头,最小值顶着底,相对会好看一些吧?
    嗯呢,我设置一个padding
  1. 滑块、滑道的高度,会随着组件设置的 height 自动适配吧?
    已改造

@hustcc hustcc self-requested a review July 7, 2021 12:46
refactor(slider): rename type Image to image
@hustcc hustcc merged commit f038f43 into antvis:master Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants