This repository was archived by the owner on Oct 7, 2023. It is now read-only.
refactor marker #36
Merged
refactor marker #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aarebecca
commented
Jul 15, 2021
Aarebecca
commented
- 完善单测
- 调整了代码结构，将parseMarker移至util
- 修改了案例
- 具有update方法
Pull Request Test Coverage Report for Build 1032601589
💛 - Coveralls |
|
@hustcc 单测文件命名有规范吗？我觉得可以同 G2Plot 统一，以及 G2 5.0 后续也保持 xxx-spec.ts 的格式 |
visiky
approved these changes
Jul 18, 2021
|
考虑改一下 单测文件命名 |
好的 |
|
冲突了，git rebase 一下 master。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.