Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hexagon_map #182

Merged
merged 3 commits into from
Feb 1, 2020
Merged

Fix hexagon_map #182

merged 3 commits into from
Feb 1, 2020

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Jan 31, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

tests-checker[bot]
tests-checker bot suggested changes Jan 31, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented Jan 31, 2020

This pull request introduces 3 alerts when merging 526089c into ec0423b - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lzxue lzxue merged commit be1ee20 into master Feb 1, 2020
@lzxue lzxue deleted the fix_hexagomap branch February 1, 2020 13:09
lzxue added a commit that referenced this pull request Mar 5, 2020
@lzxue
Merge pull request #182 from antvis/fix_hexagomap
ef0c615 
Fix hexagon_map
lzxue added a commit that referenced this pull request Mar 5, 2020
@lzxue
Merge pull request #182 from antvis/fix_hexagomap
85d0192 
Fix hexagon_map
lzxue added a commit that referenced this pull request Mar 5, 2020
@lzxue
Merge pull request #182 from antvis/fix_hexagomap
2295532 
Fix hexagon_map
lzxue added a commit that referenced this pull request Mar 6, 2020
@lzxue
Merge pull request #182 from antvis/fix_hexagomap
c60e405 
Fix hexagon_map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lzxue