Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/qbi color size update #228

Merged
merged 4 commits into from
Feb 27, 2020
Merged

Fix/qbi color size update #228

merged 4 commits into from
Feb 27, 2020

Conversation

wufenfen
Copy link
Contributor

  • 修复地图更新bug
  • 修复地图autoFit的bug,待优化
  • 修复类型错误

@todo
Copy link

todo bot commented Feb 27, 2020

:目前这种处理会频繁更新,但是直接JSON.Stringify(size.values),回调函数不会更新,待优化

// TODO:目前这种处理会频繁更新,但是直接JSON.Stringify(size.values),回调函数不会更新,待优化
}, [color.field, color.scale, color.values]);
return null;
});


This comment was generated by todo based on a TODO comment in 09f2ff8 in #228. cc @antvis.

@todo
Copy link

todo bot commented Feb 27, 2020

:目前这种处理会频繁更新,但是直接JSON.Stringify(size.values),回调函数不会更新,待优化

// TODO:目前这种处理会频繁更新,但是直接JSON.Stringify(size.values),回调函数不会更新,待优化
}, [size.field, size.values, size.scale]);
return null;
});


This comment was generated by todo based on a TODO comment in 09f2ff8 in #228. cc @antvis.

@todo
Copy link

todo bot commented Feb 27, 2020

:是否可以统一到Layer的option里,目前问题是Layer的autoFit一直为true,无法触发更新

// TODO:是否可以统一到Layer的option里,目前问题是Layer的autoFit一直为true,无法触发更新
if (sourceOption.autoFit) {
layer.fitBounds();
}
}, [data, JSON.stringify(sourceOption)]);
return null;


This comment was generated by todo based on a TODO comment in b85db61 in #228. cc @antvis.

@lzxue lzxue merged commit a5894b7 into master Feb 27, 2020
@lzxue lzxue deleted the fix/qbi-color-size-update branch February 27, 2020 03:26
@pr-triage pr-triage bot added the PR: merged label Feb 27, 2020
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants