Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heatmap3d #268

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Heatmap3d #268

merged 2 commits into from
Mar 26, 2020

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Mar 26, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

tests-checker[bot]
tests-checker bot suggested changes Mar 26, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented Mar 26, 2020

This pull request introduces 1 alert when merging d56e8d6 into 0f67b98 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lzxue lzxue merged commit 3bc65f5 into master Mar 26, 2020
@lzxue lzxue deleted the heatmap3d branch March 26, 2020 09:13
lzxue added a commit that referenced this pull request Apr 13, 2020
@lzxue
Merge pull request #268 from antvis/heatmap3d
4e6666c 
Heatmap3d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lzxue