Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

District #378

Merged
merged 16 commits into from
May 20, 2020
Merged

District #378

merged 16 commits into from
May 20, 2020

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented May 19, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request introduces 1 alert when merging a40b4fa into 17cca41 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request fixes 1 alert when merging 9dce2c6 into 33e06ab - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lzxue lzxue merged commit 2ef3257 into master May 20, 2020
@lzxue lzxue deleted the District branch May 20, 2020 02:19
lzxue added a commit that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant