Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add component #45

Merged
merged 4 commits into from
Oct 25, 2019
Merged

add component #45

merged 4 commits into from
Oct 25, 2019

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Oct 25, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

tests-checker[bot]
tests-checker bot suggested changes Oct 25, 2019
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2019

This pull request introduces 17 alerts and fixes 4 when merging b783a9a into ff0ffa0 - view on LGTM.com

new alerts:

  • 16 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable

fixed alerts:

  • 4 for Unused variable, import, function or class

@lzxue lzxue merged commit 4072f62 into next Oct 25, 2019
lzxue added a commit that referenced this pull request Mar 5, 2020
@lzxue
Merge pull request #45 from antvis/encode
b61be25 
add component
lzxue added a commit that referenced this pull request Mar 6, 2020
@lzxue
Merge pull request #45 from antvis/encode
161f966 
add component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lzxue