Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site #62

Merged
merged 13 commits into from
Nov 18, 2019
Merged

Site #62

merged 13 commits into from
Nov 18, 2019

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Nov 18, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2019

This pull request introduces 21 alerts and fixes 13 when merging daad37a into 077c351 - view on LGTM.com

new alerts:

  • 20 for Unused variable, import, function or class
  • 1 for Duplicate property

fixed alerts:

  • 12 for Unused variable, import, function or class
  • 1 for Overwritten property

@lzxue lzxue merged commit e5c3187 into next Nov 18, 2019
@lzxue lzxue deleted the site branch November 18, 2019 11:52
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 5, 2020
lzxue added a commit that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants