-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix site map #846
Fix site map #846
Conversation
😭 Deploy PR Preview 48e87f5 failed. Build logs 🤖 By surge-preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
|
||
return ( | ||
<div style={{ background: '#fff', borderRadius: 3 }}> | ||
<Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
<Option value="示例地区1">示例地区1</Option> | ||
<Option value="示例地区2">示例地区2</Option> | ||
</Select> | ||
<Select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
{dipper.map(item => { | ||
return ( | ||
<div key={item.title} className='dipperitem' > | ||
<img className='dipperimg' src={item.image} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
</div> | ||
) : ( | ||
<div className={styles.edit}> | ||
<Input defaultValue={meshName} ref={ref} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
Checklist
npm test
passesDescription of change