Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site map #846

Merged
merged 8 commits into from
Nov 21, 2021
Merged

Fix site map #846

merged 8 commits into from
Nov 21, 2021

Conversation

lzxue
Copy link
Contributor

@lzxue lzxue commented Nov 21, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2021

😭 Deploy PR Preview 48e87f5 failed. Build logs

🤖 By surge-preview

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.


return (
<div style={{ background: '#fff', borderRadius: 3 }}>
<Select
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

<Option value="示例地区1">示例地区1</Option>
<Option value="示例地区2">示例地区2</Option>
</Select>
<Select
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

{dipper.map(item => {
return (
<div key={item.title} className='dipperitem' >
<img className='dipperimg' src={item.image} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

</div>
) : (
<div className={styles.edit}>
<Input defaultValue={meshName} ref={ref} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

@lzxue lzxue merged commit 975fa57 into master Nov 21, 2021
@lzxue lzxue deleted the fix_site_map branch November 21, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant