fix(compatibility): 传值 dom 校验 style 属性 #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolution
refactor(gl-matrix): 删除覆盖的方法,使用新的 export 语法
fix(matrix): 修复部分 TypeScript 版本不支持 export * 的问题
refactor(marix-util): 将 matrix-util 扩展的方法同 gl-matrix 的命名空间平级导出
feat(matrix): export more methods
fix: remove lib import
* feat: add util of get-max and get-min value * test: 添加 max、min单测 * fix(get-range): 使用max、min获取最大最小值 * chore: update @antv/util to 2.0.11 * feat(omit): add a util of omit & add testcase
* chore: add ci * Update build.yml * chore: update build
* perf(uniq): perf fo uniq function * chore: groupBy * chore: 2.0.12 * perf: use for loop replace for of
* fix: maxBy minBy for empty data * chore: fix typo * chore: fix unit test * chore: fix unit test
使用 @ant-design/charts 偶现从底层依赖库报错，兼容下 Uncaught TypeError: Cannot read property 'marginBottom' of undefined
hustcc
reviewed
Sep 3, 2021
packages/dom-util/src/modify-css.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| export default function modifyCSS(dom: HTMLElement, css: { [key:string]: any }): HTMLElement { | |||
| if (dom) { | |||
| if (dom && dom.style) { | |||
visiky
reviewed
Jan 28, 2022
packages/dom-util/src/modify-css.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| export default function modifyCSS(dom: HTMLElement, css: { [key:string]: any }): HTMLElement { | |||
| if (dom) { | |||
| if (dom && dom.style) { | |||
There was a problem hiding this comment.
理论上，modifyCSS 如果 dom.style 为空，应该让其设置为 dom.style = {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用 @ant-design/charts 偶现从底层依赖库报错
Uncaught TypeError: Cannot read property 'marginBottom' of undefined
环境：Windows 7
浏览器：BIDUBrowser 6