Theme: add new some themes

[IRMABaitussalam]

No description provided.

[vercel]

@IRMABaitussalam is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Automated Theme Preview

Hi, thanks for the theme contribution. Please read our theme contribution guidelines.

Warning

Keep in mind that we already have a vast collection of different themes. To keep their number manageable, we began to add only themes supported by the community. Your pull request with theme addition will be merged once we get enough positive feedback from the community in the form of thumbs up (see #1935). Remember that you can also support themes of other contributors that you liked to speed up their merge.

Note

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

✔️ Theme PR does adhere to our guidelines.

Test results

• ✔️ qamariyah
• ✔️ darkes_cadillac
• ✔️ darkes_mercury
• ✔️ darkes_sun

Result: ✔️ All themes are valid.

Details

Qamariyah theme preview

title_color: #416284 | icon_color: #294f50 | text_color: #382a1f | bg_color: #ededeb

Preview Link

Darkes_cadillac theme preview

title_color: #e12d99 | icon_color: #e0b4bc | text_color: #ffffff | bg_color: #090b0c

Preview Link

Darkes_mercury theme preview

title_color: #747c7c | icon_color: #839aa7 | text_color: #ffffff | bg_color: #090b0c

Preview Link

Darkes_sun theme preview

title_color: #fca311 | icon_color: #f55119 | text_color: #ffffff | bg_color: #090b0c

Preview Link

[github-actions]

Some themes are invalid. See the Automated Theme Preview comment above for more information.

[rickstaa]

@IRMABaitussalam, although I love the themes, I think it is a bit hard for us to review the popularity of your themes when you included so many in your PRs.

@qwerty541, @anuraghazra, what do you think should update the theme preview CI to display a warning when multiple themes are added or maybe let it add a batch label? I initially added the option for multiple themes to allow people to supply both a dark an light version of a theme 🤔.

[qwerty541]

@IRMABaitussalam, although I love the themes, I think it is a bit hard for us to review the popularity of your themes when you included so many in your PRs.

@qwerty541, @anuraghazra, what do you think should update the theme preview CI to display a warning when multiple themes are added or maybe let it add a batch label? I initially added the option for multiple themes to allow people to supply both a dark an light version of a theme 🤔.

@rickstaa I think that we can update our themes contribution guidelines wtih adding a new rule - one theme per pull request. May be sutiations when user wants to add some versions of same theme can be exceptional. I hope it will be enough for now. If users continue adding pull requests with batch of themes we can update our theme review script to request changes instead of approving in such cases. I can open pull request with changes into documentation if you are up to merge.

[rickstaa]

@IRMABaitussalam, although I love the themes, I think it is a bit hard for us to review the popularity of your themes when you included so many in your PRs.
@qwerty541, @anuraghazra, what do you think should update the theme preview CI to display a warning when multiple themes are added or maybe let it add a batch label? I initially added the option for multiple themes to allow people to supply both a dark an light version of a theme 🤔.

@rickstaa I think that we can update our themes contribution guidelines wtih adding a new rule - one theme per pull request. May be sutiations when user wants to add some versions of same theme can be exeptional. I hope it will be enough for now. If users continue adding pull requests with batch of themes we can update our theme review script to request changes instead of approving in such cases. I can open pull request with changes into documentation if you are up to merge.

That sounds like a good start! How should we deal with dark and light themes? Do we still allow, for example, github_dark and github_light in one pull request? If not, we can update the pull request action to request changes 👍🏻.

[qwerty541]

@IRMABaitussalam, although I love the themes, I think it is a bit hard for us to review the popularity of your themes when you included so many in your PRs.
@qwerty541, @anuraghazra, what do you think should update the theme preview CI to display a warning when multiple themes are added or maybe let it add a batch label? I initially added the option for multiple themes to allow people to supply both a dark an light version of a theme 🤔.

@rickstaa I think that we can update our themes contribution guidelines wtih adding a new rule - one theme per pull request. May be sutiations when user wants to add some versions of same theme can be exeptional. I hope it will be enough for now. If users continue adding pull requests with batch of themes we can update our theme review script to request changes instead of approving in such cases. I can open pull request with changes into documentation if you are up to merge.

That sounds like a good start! How should we deal with dark and light themes? Do we still allow, for example, github_dark and github_light in one pull request? If not, we can update the pull request action to request changes 👍🏻.

How should we deal with dark and light themes?

I think that sutiations when user wants to add some versions of same theme can be exceptional.

If not, we can update the pull request action to request changes 👍🏻.

If users continue adding pull requests with batch of themes after changes in documentation we can update our theme review script to request changes instead of approving in such cases.

[qwerty541]

@rickstaa I have just opened two pull requests with documentation updated (#3394 and #3395). Please check it out.

[anuraghazra]

We are currently pausing addition of new themes. If this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.