Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify warm_quic_cache_service instantiation #1063

Merged

Conversation

lijunwangs
Copy link

Problem

simplify warm_quic_cache_service instantiation

Summary of Changes

Fixes #

Copy link

mergify bot commented Apr 26, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link

mergify bot commented Apr 26, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.0%. Comparing base (8e331e1) to head (0f3f152).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1063   +/-   ##
=======================================
  Coverage    82.0%    82.0%           
=======================================
  Files         860      860           
  Lines      232898   232892    -6     
=======================================
- Hits       191071   191067    -4     
+ Misses      41827    41825    -2     

@lijunwangs lijunwangs merged commit d87e23d into anza-xyz:master Apr 26, 2024
40 checks passed
mergify bot pushed a commit that referenced this pull request Apr 26, 2024
* simplify warm_quic_cache_service instantiation

(cherry picked from commit d87e23d)

# Conflicts:
#	core/src/tvu.rs
mergify bot pushed a commit that referenced this pull request Apr 26, 2024
* simplify warm_quic_cache_service instantiation

(cherry picked from commit d87e23d)

# Conflicts:
#	core/src/tvu.rs
lijunwangs added a commit that referenced this pull request Apr 26, 2024
#1068)

Disable connection cache warmer for tpu if no rpc services using it.

(cherry picked from commit d87e23d)

# Conflicts:
#	core/src/tvu.rs

* Merge conflicts

---------

Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Apr 29, 2024
#1068)

Disable connection cache warmer for tpu if no rpc services using it.

(cherry picked from commit d87e23d)

# Conflicts:
#	core/src/tvu.rs

* Merge conflicts

---------

Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
(cherry picked from commit f09d04d)
lijunwangs pushed a commit that referenced this pull request Apr 29, 2024
#1068)

Disable connection cache warmer for tpu if no rpc services using it.

(cherry picked from commit d87e23d)

# Conflicts:
#	core/src/tvu.rs

* Merge conflicts

---------

Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
(cherry picked from commit f09d04d)
lijunwangs pushed a commit that referenced this pull request Apr 30, 2024
… (backport of #1068) (#1108)

v1.18: Disable cache warmer if RPC is not using it (backport of #1063) (#1068)

Disable connection cache warmer for tpu if no rpc services using it.

(cherry picked from commit d87e23d)

# Conflicts:
#	core/src/tvu.rs

* Merge conflicts

---------

Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
(cherry picked from commit f09d04d)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…xyz#1063) (anza-xyz#1068)

Disable connection cache warmer for tpu if no rpc services using it.

(cherry picked from commit d87e23d)

# Conflicts:
#	core/src/tvu.rs

* Merge conflicts

---------

Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants