v1.18: Disable cache warmer if RPC is not using it (backport of #1063) #1068
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* simplify warm_quic_cache_service instantiation (cherry picked from commit d87e23d) # Conflicts: # core/src/tvu.rs
|
Cherry-pick of d87e23d has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
lijunwangs
changed the title
| @@ -1306,7 +1306,7 @@ impl Validator { | |||
| config.wait_to_vote_slot, | |||
| accounts_background_request_sender, | |||
| config.runtime_config.log_messages_bytes_limit, | |||
| &connection_cache, | |||
| json_rpc_service.is_some().then_some(&connection_cache), // for the cache warmer only used for STS for RPC service | |||
There was a problem hiding this comment.
It looks like we can avoid creating connection_cache entirely if json_rpc_service.is_none()?
There was a problem hiding this comment.
we can't, the forwarder still uses the cache
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #1068 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 827 827
Lines 225387 225390 +3
=======================================
+ Hits 183996 184053 +57
+ Misses 41391 41337 -54 |
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
… (backport of #1068) (#1108) v1.18: Disable cache warmer if RPC is not using it (backport of #1063) (#1068) Disable connection cache warmer for tpu if no rpc services using it. (cherry picked from commit d87e23d) # Conflicts: # core/src/tvu.rs * Merge conflicts --------- Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com> (cherry picked from commit f09d04d) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…xyz#1063) (anza-xyz#1068) Disable connection cache warmer for tpu if no rpc services using it. (cherry picked from commit d87e23d) # Conflicts: # core/src/tvu.rs * Merge conflicts --------- Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
Problem
Disable cache warmer if RPC is not using it
Summary of Changes
Fixes #
This is an automatic backport of pull request #1063 done by [Mergify](https://mergify.com).