Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.17: Disable cache warmer if RPC is not using it (backport of #1063) (backport of #1068) #1108

Merged
merged 1 commit into from
Apr 30, 2024
Merged

v1.17: Disable cache warmer if RPC is not using it (backport of #1063) (backport of #1068) #1108

merged 1 commit into from
Apr 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 29, 2024

Problem

Disable cache warmer if RPC is not using it

Summary of Changes

Fixes #

This is an automatic backport of pull request #1063 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #1068 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner April 29, 2024 19:33
@mergify mergify bot requested a review from a team as a code owner April 29, 2024 19:33
@lijunwangs lijunwangs mentioned this pull request Apr 29, 2024
Closed
@mergify @lijunwangs
v1.18: Disable cache warmer if RPC is not using it (backport of #1063) (
f372d87 
#1068)

Disable connection cache warmer for tpu if no rpc services using it.

(cherry picked from commit d87e23d)

# Conflicts:
#	core/src/tvu.rs

* Merge conflicts

---------

Co-authored-by: Lijun Wang <83639177+lijunwangs@users.noreply.github.com>
(cherry picked from commit f09d04d)
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.6%. Comparing base (a0020cf) to head (f372d87).

Additional details and impacted files 
@@            Coverage Diff            @@
##            v1.17    #1108     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         806      806             
  Lines      219335   219338      +3     
=========================================
- Hits       179108   179087     -21     
- Misses      40227    40251     +24

@t-nelson
Copy link

t-nelson commented Apr 29, 2024 •
edited
Loading

i'm gonna bow out of bp approval since i approved master

@t-nelson
Copy link

t-nelson commented Apr 29, 2024 •
edited
Loading

i'm gonna bow out of bp approval since i approved master

lies, that was the 1.18 bp pr

@lijunwangs lijunwangs changed the title v1.17: v1.18: Disable cache warmer if RPC is not using it (backport of #1063) (backport of #1068) v1.17: Disable cache warmer if RPC is not using it (backport of #1063) (backport of #1068) Apr 30, 2024
@lijunwangs lijunwangs merged commit 4f9c393 into v1.17 Apr 30, 2024
33 checks passed
@lijunwangs lijunwangs deleted the mergify/bp/v1.17/pr-1068 branch April 30, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgarg66 pgarg66 pgarg66 approved these changes

@CriesofCarrots CriesofCarrots CriesofCarrots approved these changes

@t-nelson t-nelson t-nelson approved these changes

@alessandrod alessandrod Awaiting requested review from alessandrod

@sakridge sakridge Awaiting requested review from sakridge

Assignees

@lijunwangs lijunwangs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codecov-commenter @t-nelson @CriesofCarrots @pgarg66 @lijunwangs