v1.18: RPC: fix numNonVoteTransactions in getPerformanceSamples (backport of #1189) #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 3f6c567)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #1208 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 827 827
Lines 225352 225352
=========================================
- Hits 184043 184036 -7
- Misses 41309 41316 +7 |
CriesofCarrots
approved these changes
May 7, 2024
yihau
approved these changes
May 8, 2024
jstarry
approved these changes
May 8, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…port of anza-xyz#1189) (anza-xyz#1208) RPC: fix numNonVoteTransactions in getPerformanceSamples (anza-xyz#1189) (cherry picked from commit 3f6c567) Co-authored-by: Justin Starry <justin@anza.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The value
numNonVoteTransactionsreturned in the RPCgetPerformanceSamplesendpoint was actually reporting the number of successful non vote transactions that were executed. That field is documented in the RPC docs with the following statement:But before this fix,
numTransactions - numNonVoteTransactionis actually computing the number of vote transactions + errored non-vote transactions.Summary of Changes
executed_non_vote_transactions_countwhether the non-vote tx failed or succeeded. This value will get fixed on restart since we don't persist the value in snapshotsFixes #
This is an automatic backport of pull request #1189 done by [Mergify](https://mergify.com).