-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load balance by CUs #1221
load balance by CUs #1221
Conversation
batches_per_thread[thread_id].len() + in_flight_per_thread[thread_id], | ||
) | ||
}) | ||
.min_by(|a, b| a.1.cmp(&b.1)) | ||
.map(|(thread_id, _)| thread_id) | ||
.min_by(|a, b| a.1.cmp(&b.1).then_with(|| a.2.cmp(&b.2))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still use the number of txs as a backup comparison if the CUs happen to be exactly equal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 886 886
Lines 236439 236453 +14
=======================================
+ Hits 194252 194320 +68
+ Misses 42187 42133 -54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 41e2c96)
Problem
Summary of Changes
Fixes #