-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default staked client in LocalCluster #716
default staked client in LocalCluster #716
Conversation
For comparison, local-cluster 2 went from 27m -> 14m with this change. 5 went from 19m -> 10m. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #716 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 851 851
Lines 230726 230726
=======================================
+ Hits 189009 189037 +28
+ Misses 41717 41689 -28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
match
on a bool
kinda makes my eye twitch. lgtm otherwise
I just copied the match from the original location below. 🤔 |
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs
* default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs
yeah saw that. my eye twitched on the red lines even |
Created an commmented on #726, didn't wanna delay backports on a style change since this is blocking other backports. |
… (anza-xyz#724) * default staked client in LocalCluster (anza-xyz#716) * default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Problem
Summary of Changes
Fixes #