Qc tests adjustments part3 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid errors when trying to move files with the same source/destination names.
The updates are to support quick testing and to avoid the UI being broken by a certain datasets with some missing fields.
This fix a bug for downlooking adcp introduced when we changed the interpolation function and cleanup a variable not used. A constraint for the interpolation function is that the values along all dimensions should be increasing. This fix just shift the value within the function closure so we can perform interpolation of downlooking bins.
In a recent commit, the memory saving option to use memory mapped files was commented out. This turn the feature on for good.
This fix a compatibility problem introduced recently by using the de2bi function. This function may not be avaiable to everyone. Hence, the old bit wrangling was restore for all variables affected.
This commit introduces functionality to allow easy update to Property/Mapping files while keeping their comment structure. `Util/detectMappingsDelimiter` detects the delimiter of a Parameter/Mapping file. `Util/callerName.m` detects the function calling it from the current workspace. `Util/updateMappings` perform the update for a given configuration name and value. `Util/+IMOS/+resolve/function_parameters` automatically resolve/load the parameters of the current running function. This function substitutes `readProperty.m`. `Util/+IMOS/+update/function_parameters` as above, but update the file with parameters as arguments. This function, in particular, is not used yet but may be a good substitute to `writeProperty.m`. For usage examples, see imosEchoIntensitySetQC, imosSurfaceDetectionByDepthSetQC, and associated tests.
`IMOS.variables_with_dimensions` implements a filterby/groupby action on variables based on dimensions names, in order.
This provide some basic adcp query functions. `IMOS.adcp.beam_height` - computes the total beam height/length of adcp. `IMOS.adcp.bin_in_water` - computes the points of the adcp profile that are within the water, based on the beam_face config, beam_height, instrument depth, and local bathymetry. `IMOS.adcp.contains_adcp_dimensions` - check if a dataset contains typical adcp dimensions. `IMOS.adcp.is_along_beam` - check if the data is collected in beam coordinates. `IMOS.adcp.number_of_beams` - return the number of beams based on variable content.
Includes some repeatable patterns of query/meta data access. `IMOS.meta.beam_face_config` - discover the beam face config of an ADCP. `IMOS.meta.site_bathymetry` - discover the local bathymetry. `IMOS.meta.velocity_variables` - discover all velocity variables in a dataset.
This implements a simple function based schema validation for PP/QC routines. The idea is to externalise some long verification calls and inspections of individual routines and turn the actual code that perform the PP/QC cleaner. The schemas must be named exactly as functions within the `+schema` folder. `IMOS.validate_dataset` perform a schema validation of a function. For practical examples, see imosEchoIntensitySetQC & imosSurfaceDetectionByDepthSetQC.
This re-implements the EchoIntensityQC test with the objective of deprecating EchoIntensityVelocitySetQC. The major advantages are a cleaner code and customisable behaviour: 1. Propagate - to propagate a echo gradient further down the beam. 2. Bound by index - to limit markings by bin index. 3. Bound by depth - to limit markings by depth value. See also tests and documentation.
The `imosSurfaceDetectionByDepthSetQC` function implements a simple surface detection based on the instrument depth and the beam height of the adcp. Supports both up-looking and down-looking adcps.
This was actually a very old code imported when we merged the 675 branch. Current QC functions like `EchoIntensityVelocity`, the reimplemented one `EchoIntensity`, or the new `SurfaceDetectionByDepth` may achieve equivalent results.
This clean up the function from the license block and fix enu detection in the test given the changes done at the workhorseParse function.
Closed
lbesnard
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs. This is part3 of the next release.