Increase text contrast to AAA accessibility level #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aos
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @aos! Thanks for the theme, it's quite nice. I noticed that the theme falls short of 100% accessibility due to the low contrast of the footnote and footer elements. This PR darkens the color of these grey elements to
#575757, the maximum lightness that still achieves the desired contrast ratio of 7. You can take a look at this online contrast checker to try for yourself (the page's background is#FCFCFC).The PR also removes the need for
!importanton.footnote aby changing.posts li ato.posts li > ato avoid unwanted side effects.