Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bench script compatible with neovim #127

Closed
wants to merge 1 commit into from

Conversation

chr4
Copy link

@chr4 chr4 commented May 7, 2020

No description provided.

@ap
Copy link
Owner

ap commented May 7, 2020

Thank you for the patch. Sorry that I won’t be taking it, though.

The immediate reason is that your change makes the script pick up any after/syntax/css.vim – not specifically the one belonging to this plugin.

The broader reason is that in looking at how to address that, it seems to me that the script must long have gone entirely broken, regardless of the flavour of Vim in use. It was a long time ago that the plugin consisted only of after/syntax/css.vim. It was an even longer time ago that placing that path directly below ~/.vim was the usual method of installing the plugin. I’m pretty sure that either the time accrued to autoload/css_color.vim is more important, and/or the time accrued to other files also needs accounting for. The pattern match is not written to expect any part of the contemporary situation.

I don’t know off hand how the correct patch would have to look like so I can’t really give guidance on updating it.

@chr4
Copy link
Author

chr4 commented May 7, 2020

I've been using this to hunt down my performance issues described in #126 - but this was quite a while ago.

Thanks for the explanation! Closing this.

@chr4 chr4 closed this May 7, 2020
@ap ap mentioned this pull request May 7, 2020
adamhotep added a commit to adamhotep/vim-css-color that referenced this pull request May 29, 2023
also made the default run (all test files) work from any directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants