-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new bulk import API in shell #470
Comments
@keith-turner do you think the shell should support the old and new bulk import APIs? |
The shell has its own API. I don't think we need to confuse it with multiple commands that map to different Java APIs. We can just change its options, for example, to make failure directory optional. |
So you are saying have the one command support both? If you pass a failure directory use the old technique, otherwise use the new one? |
One command, but should use the new implementation if the failure directory isn't specified. |
Perhaps... but I think it might be better to only use the new one, leaving the failure directory arg as optional, so it doesn't break people who provide one, and give a deprecation warning if they do provide one. |
Think we need to worry about backwards compatibility? The way the CLI options work, I think I am going to have to change the command from: |
I found the NO_FIXED_ARG_LENGTH_CHECK so I will make the command work with old and new based on number of parameters. |
The shell importdirectory command will now support both the old and new versions of bulk import, based on the number of arguments provided.
This is follow up work for #436. Need to support the new bulk import API in the shell.
The text was updated successfully, but these errors were encountered: