Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new bulk import API in shell #470

Closed
keith-turner opened this issue May 7, 2018 · 7 comments
Closed

Support new bulk import API in shell #470

keith-turner opened this issue May 7, 2018 · 7 comments
Assignees
Labels
blocker This issue blocks any release version labeled on it. enhancement This issue describes a new feature, improvement, or optimization.
Milestone

Comments

@keith-turner
Copy link
Contributor

This is follow up work for #436. Need to support the new bulk import API in the shell.

@keith-turner keith-turner added v2.0.0 blocker This issue blocks any release version labeled on it. enhancement This issue describes a new feature, improvement, or optimization. labels May 7, 2018
@milleruntime milleruntime self-assigned this May 16, 2018
@milleruntime
Copy link
Contributor

@keith-turner do you think the shell should support the old and new bulk import APIs?

@ctubbsii
Copy link
Member

The shell has its own API. I don't think we need to confuse it with multiple commands that map to different Java APIs. We can just change its options, for example, to make failure directory optional.

@milleruntime
Copy link
Contributor

So you are saying have the one command support both? If you pass a failure directory use the old technique, otherwise use the new one?

@ctubbsii
Copy link
Member

One command, but should use the new implementation if the failure directory isn't specified.

@ctubbsii
Copy link
Member

Perhaps... but I think it might be better to only use the new one, leaving the failure directory arg as optional, so it doesn't break people who provide one, and give a deprecation warning if they do provide one.

@milleruntime
Copy link
Contributor

Think we need to worry about backwards compatibility? The way the CLI options work, I think I am going to have to change the command from:
importdirectory <directory> <failureDirectory> true|false
to
importdirectory <directory> true|false [-f <directory>]

@milleruntime
Copy link
Contributor

I found the NO_FIXED_ARG_LENGTH_CHECK so I will make the command work with old and new based on number of parameters.

milleruntime added a commit to milleruntime/accumulo that referenced this issue Jul 26, 2018
The shell importdirectory command will now support both the old and new
versions of bulk import, based on the number of arguments provided.
@ctubbsii ctubbsii added this to the 2.0.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue blocks any release version labeled on it. enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Development

No branches or pull requests

3 participants