Use micrometer noop classes for default meter initialization #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EdColeman
commented
May 10, 2024
•
EdColeman
commented
- removes custom NoOpDistributionSummary
- adds default initializations for other meter types
- sorts the MetricsIT excludes and turns off formatting so they stay on a single line to help diffs in merges
- removes custom NoOpDistributionSummary - adds default initializations for other meter types
dlmarion
reviewed
May 13, 2024
server/base/src/main/java/org/apache/accumulo/server/metrics/NoopMetrics.java
Show resolved
Hide resolved
dlmarion
approved these changes
May 24, 2024
added 5 commits
May 24, 2024 23:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.