Always balance root and metadata tables #4709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
|
@keith-turner - good catch on these latest comments. I had some things outside of the loop that should have been inside of it. |
keith-turner
reviewed
Jul 3, 2024
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java
Outdated
Show resolved
Hide resolved
keith-turner
approved these changes
Jul 5, 2024
keith-turner
reviewed
Jul 5, 2024
| int i = 0; | ||
| do { | ||
| i++; | ||
| log.debug("Balancing for tables at level {}, times-in-loop: {}", dl, i); |
There was a problem hiding this comment.
The times in loop info is nice, w/o it would have to dig through logs and look for changes in level.
dlmarion
added a commit
to dlmarion/accumulo
that referenced
this pull request
Jul 9, 2024
4 ITs failing. These changes get the ITs working again. Related to apache#4709
dlmarion
added a commit
to dlmarion/accumulo
that referenced
this pull request
Jul 9, 2024
The changes to Manager.balanceTablets in 4709 left 4 ITs failing. These changes get the ITs working again. Related to apache#4709
dlmarion
added a commit
that referenced
this pull request
Jul 23, 2024
The changes to Manager.balanceTablets in 4709 left 4 ITs failing. These changes get the ITs working again. Related to #4709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4515