Skip to content

Commit

Permalink
NO-JIRA removing useless assertionRemainingMessages
Browse files Browse the repository at this point in the history
JMSTestCase is deprecated anyway.
in its older form many many years ago a server would be reused over
between tests.

what forced us to make such verification to avoid messages from one test
leaking into the next.

This was because a server startup was expensive many years ago (less
efficient code and the hardware available 10 years ago)

with the current state of things this is not needed as the server will
be started from scratch on every test
  • Loading branch information
clebertsuconic committed May 25, 2022
1 parent 3ea18a8 commit c259325
Showing 1 changed file with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@ public void setUp() throws Exception {
cf = new ActiveMQJMSConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");
queueCf = new ActiveMQQueueConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");
topicCf = new ActiveMQTopicConnectionFactory("tcp://127.0.0.1:61616?blockOnAcknowledge=true&blockOnDurableSend=true&blockOnNonDurableSend=true");

assertRemainingMessages(0);
}

protected final JMSContext createContext() {
Expand Down Expand Up @@ -115,8 +113,6 @@ public void tearDown() throws Exception {
}

cf = null;

assertRemainingMessages(0);
}

protected Connection createConnection(ConnectionFactory cf1) throws JMSException {
Expand Down

0 comments on commit c259325

Please sign in to comment.