Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In some cases 'cancel-workflow-run' action crashes #15188

Closed
potiuk opened this issue Apr 4, 2021 · 0 comments · Fixed by #15189
Closed

In some cases 'cancel-workflow-run' action crashes #15188

potiuk opened this issue Apr 4, 2021 · 0 comments · Fixed by #15189
Assignees
Labels
kind:bug This is a clearly a bug

Comments

@potiuk
Copy link
Member

potiuk commented Apr 4, 2021

In some cases, when the PR is weird - when there is an empty PR that gets closed quickly I guess such as:

https://github.com/apache/airflow/runs/2265280777?check_suite_focus=true,

the 'cancel-workflow-runs' action crashes:

Adding the run: 717090708 to candidates with :1029499:astronomer/airflow:bump-openapi:pull_request key.


Checking run number: 21885 RunId: 717087278 Url: https://api.github.com/repos/apache/airflow/actions/runs/717087278 Status in_progress Created at 2021-04-04T17:25:26Z


Adding the run: 717087278 to candidates with :1029499:apache/airflow:master:push key.


Checking run number: 21884 RunId: 717051432 Url: https://api.github.com/repos/apache/airflow/actions/runs/717051432 Status in_progress Created at 2021-04-04T17:02:39Z

Error: Cannot read property 'full_name' of null

This results in cancelling all other workflows and is an easy way to DDOs airflow. It can be handled by cancelling the offending workflow. This should be handled better

UPDATE: this hppens where "head_repository" is null - which is somewhat error on GitHub side. But still we should handle it better.

Apache Airflow version:

Kubernetes version (if you are using kubernetes) (use kubectl version):

Environment:

  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

What happened:

What you expected to happen:

How to reproduce it:

Anything else we need to know:

@potiuk potiuk added the kind:bug This is a clearly a bug label Apr 4, 2021
@potiuk potiuk self-assigned this Apr 4, 2021
potiuk added a commit to potiuk/airflow that referenced this issue Apr 4, 2021
potiuk added a commit that referenced this issue Apr 5, 2021
ashb pushed a commit that referenced this issue Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant