Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Authlib in Airflow Docker images #16944

Closed
vkostyuk opened this issue Jul 12, 2021 · 3 comments · Fixed by #17093 or #17208
Closed

Include Authlib in Airflow Docker images #16944

vkostyuk opened this issue Jul 12, 2021 · 3 comments · Fixed by #17093 or #17208
Labels
area:production-image Production image improvements and fixes kind:feature Feature Requests

Comments

@vkostyuk
Copy link

Description

Authlib is required for FAB authentication. Currently, it's not included in the Airflow images and must be pip installed separately. It's a small package supporting core functionality (Webserver UI authentication), hence would make sense to include.
@vkostyuk vkostyuk added the kind:feature Feature Requests label Jul 12, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 12, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk potiuk assigned potiuk and unassigned potiuk Jul 12, 2021
@potiuk
Copy link
Member

potiuk commented Jul 12, 2021 •
edited

Would you like to make a PR with it @vkostyuk ? Should not be too difficult to find the right place in either Dockerfile (same thing should be done in Dockerfile.ci)

@jedcunningham jedcunningham added the area:production-image Production image improvements and fixes label Jul 12, 2021
potiuk added a commit to potiuk/airflow that referenced this issue Jul 19, 2021
@potiuk
Adds oauth libraries to PROD docker image
1e6ef85 
The flask OAuth requires oauth libraries and this case is
frequent enough to be added to the reference image.

Fixes: apache#16944
@potiuk potiuk mentioned this issue Jul 19, 2021
Merged
uranusjr pushed a commit that referenced this issue Jul 19, 2021
@potiuk
Adds oauth libraries to PROD docker image (#17093)
3234527 
The flask OAuth requires oauth libraries and this case is
frequent enough to be added to the reference image.

Fixes: #16944
@potiuk potiuk reopened this Jul 25, 2021
@potiuk
Copy link
Member

potiuk commented Jul 25, 2021

I have some clarification/real fix coming - the original fix was not really good, it still had the old dependencies linked which are not needed any more in FAB 3.

@potiuk potiuk mentioned this issue Jul 25, 2021
Merged
potiuk added a commit to potiuk/airflow that referenced this issue Jul 28, 2021
@potiuk
Updates to FlaskAppBuilder 3.3.2+
84ff29b 
There are some clarifications about using the authentication
via FlaskAppBuilder - the change implements minimum version of the
FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series
to be only authlib rather than flask-oauth.

Fixes: apache#16944 (this is the second, proper fix this time).

Depends on: apache#17290, apache#17289 - those two errors have been detected while
analysing failures in this build.
potiuk added a commit that referenced this issue Jul 28, 2021
@potiuk
Updates to FlaskAppBuilder 3.3.2+ (#17208)
6d7fa87 
There are some clarifications about using the authentication
via FlaskAppBuilder - the change implements minimum version of the
FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series
to be only authlib rather than flask-oauth.

Fixes: #16944 (this is the second, proper fix this time).
potiuk added a commit to potiuk/airflow that referenced this issue Aug 2, 2021
@potiuk
Updates to FlaskAppBuilder 3.3.2+ (apache#17208)
ac832a2 
There are some clarifications about using the authentication
via FlaskAppBuilder - the change implements minimum version of the
FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series
to be only authlib rather than flask-oauth.

Fixes: apache#16944 (this is the second, proper fix this time).
(cherry picked from commit 6d7fa87)
potiuk added a commit to potiuk/airflow that referenced this issue Aug 5, 2021
@potiuk
Updates to FlaskAppBuilder 3.3.2+ (apache#17208)
3c0f4d9 
There are some clarifications about using the authentication
via FlaskAppBuilder - the change implements minimum version of the
FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series
to be only authlib rather than flask-oauth.

Fixes: apache#16944 (this is the second, proper fix this time).
(cherry picked from commit 6d7fa87)
kaxil pushed a commit that referenced this issue Aug 17, 2021
@potiuk @kaxil
Updates to FlaskAppBuilder 3.3.2+ (#17208)
820644a 
There are some clarifications about using the authentication
via FlaskAppBuilder - the change implements minimum version of the
FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series
to be only authlib rather than flask-oauth.

Fixes: #16944 (this is the second, proper fix this time).
(cherry picked from commit 6d7fa87)
jhtimmins pushed a commit that referenced this issue Aug 17, 2021
@potiuk @jhtimmins
Updates to FlaskAppBuilder 3.3.2+ (#17208)
f729323 
There are some clarifications about using the authentication
via FlaskAppBuilder - the change implements minimum version of the
FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series
to be only authlib rather than flask-oauth.

Fixes: #16944 (this is the second, proper fix this time).
(cherry picked from commit 6d7fa87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:production-image Production image improvements and fixes kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
3 participants
@potiuk @vkostyuk @jedcunningham