Uses current sources when running k8s tests #17289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in our CI - Kubernetes tests were executed running lates ghcr.io image, rather than the image built from sources of the current PR. This PR fixes it by correctly using the PR commit as tag of the image used as base image for kubernetes tests.
jedcunningham
approved these changes
Jul 28, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jul 28, 2021
There are some clarifications about using the authentication via FlaskAppBuilder - the change implements minimum version of the FAB to 3.3.2 and clarifies the dependencies used in FAB 3 series to be only authlib rather than flask-oauth. Fixes: apache#16944 (this is the second, proper fix this time). Depends on: apache#17290, apache#17289 - those two errors have been detected while analysing failures in this build.
|
Testing also in #17208 (ti was detected there) |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 2, 2021
There was a bug in our CI - Kubernetes tests were executed running lates ghcr.io image, rather than the image built from sources of the current PR. This PR fixes it by correctly using the PR commit as tag of the image used as base image for kubernetes tests. (cherry picked from commit 396f30f)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
There was a bug in our CI - Kubernetes tests were executed running lates ghcr.io image, rather than the image built from sources of the current PR. This PR fixes it by correctly using the PR commit as tag of the image used as base image for kubernetes tests. (cherry picked from commit 396f30f)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
There was a bug in our CI - Kubernetes tests were executed running lates ghcr.io image, rather than the image built from sources of the current PR. This PR fixes it by correctly using the PR commit as tag of the image used as base image for kubernetes tests. (cherry picked from commit 396f30f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in our CI - Kubernetes tests were executed running
lates ghcr.io image, rather than the image built from sources of
the current PR.
This PR fixes it by correctly using the PR commit as tag of the
image used as base image for kubernetes tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.